Missing cpow()

[staticfloat]

I'm trying to compile our test/perf/micro set against openlibm, but we lack cpow(). I noticed that in test/libm-test.c the cpow() stuff is all #if 0'ed into oblivion; is this just because we don't need cpow() in Julia, or because of some deeper problem?

[ViralBShah]

Now that I looked at this, the reason is that the FreeBSD msun does not seem to have cpow - at least I couldn't find it. That is probably why the test was commented out. I don't think there was a deep reason for that. Somebody out there may know more about the history of cpow.

[staticfloat]

I'm having a hard time tracking this down, but it appears somehow cpow now wantssincos:

$ make
gcc -std=c99 -O0 perf.c -o bin/perf0 /home/sabae/src/julia/deps/openblas-v0.2.6/libopenblas.a /home/sabae/src/julia/deps/openlibm/libopenlibm.a -lpthread
/home/sabae/src/julia/deps/openlibm/libopenlibm.a(s_cpow.c.o): In function `cpow':
s_cpow.c:(.text+0xda): undefined reference to `sincos'
collect2: error: ld returned 1 exit status
make: *** [bin/perf0] Error 1

sincos doesn't seem to be referenced anywhere in the source except in the test suite, but a large portion of the .o files come up in a grep for it. My guess is my native libm implementation has it, so when the source files use some kind of macros, they pick it up from the native header files.

[ViralBShah]

It is perhaps easiest to find all the missing functions you run into from OpenBSD and add them. If you do not already have commit access to openlibm, I can fix that.

[staticfloat]

I would agree, except I can't seem to find a sincos in OpenBSD. It seems that it is just a simple function that takes in two references as outputs and stores the results of sin and cos into them, which I can surely write from scratch. Is that acceptable?

source: http://linux.die.net/man/3/sincos

[ViralBShah]

Seems like it is available in glibc, but this won't do as the license is GPL.

https://github.com/fidian/MathLib/blob/master/Src/s_sincos.c

You also have to write the f and l versions.

[staticfloat]

Is it alright to dump all three symbols into the same source file, or do I
need to follow some kind of naming convention for the source files? Do I
attribute myself and release the source under MIT?
-E

On Mon, Jul 15, 2013 at 9:59 AM, Viral B. Shah notifications@github.comwrote:

Seems like it is available in glibc, but this won't do as the license is
GPL.

https://github.com/fidian/MathLib/blob/master/Src/s_sincos.c

You also have to write the f and l versions.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/22#issuecomment-20983812
.

[ViralBShah]

I suggest following the same file conventions and having three files - it makes it possible to build only a 32-bit library then, for example. Otherwise, just attribute yourself and license the same as the other files. I suspect it may be BSD.