cbrtl() is not being built, and POSIX conformance

[EdSchouten]

It seems that s_cbrtl.c is not added to the list of source files in src/Make.files. It's explicitly commented out. Is this function still incomplete? If so, should we add a comment there? If not, shall we hook it up to the build?

[ViralBShah]

I recollect having some issues with it earlier, which may no longer hold. If it builds, we should hook it up again.

[EdSchouten]

Hi Viral,

It seems to build. I'll hook it up.

By the way, what are your thoughts in general on functions that are not part of the C standard/POSIX? In particular:

• gamma() (a misspelling of lgamma),
• finite() (a misspelling of isfinite),
• scalb() (a misspelling of scalbn),
• drem() (a misspelling of remainder),
• ...

I'd argue that these functions would normally be good to preserve if you have an existing commonly used implementation (FreeBSD's C library), but it would make little sense to provide those in newer or standalone implementations. I have these functions disabled in my local copy of OpenLibm, for example.

Maybe we could consider just removing them from the codebase and focussing on providing just the C/POSIX bits? If you want, I can do that at the same time.

[ViralBShah]

How about having an ifdef so that the default is POSIX, but one can build with -DLIBM_EXTENSIONS?

I think we may be using some of these in Julia. I certainly would want us to use the POSIX compliant bits only, but that would mean changing a few things on the julia side. I think POSIX compliance is the right thing to do - although I should confess that I don't know what all is part of the standard and what is not.

Once this is done, we will review the Julia usage, and remove the extensions.

[ViralBShah]

BTW, if you know of any other libm test suites, they will be great to have.

[EdSchouten]

Something like -DLIBM_EXTENSIONS sounds all right. I'll see what I can do.

[ViralBShah]

@EdSchouten You are probably busy with other things, but would be great to have a PR to make the library POSIX compliant. Coming to think of it, we can avoid LIBM_EXTENSIONS altogether. I will fix whatever is needed on the Julia side, after the cbrtl and POSIX conformance changes, if you can provide those.

I am thinking of releasing openlibm 0.5 after these. Is there anything else we should do as part of the 0.5 release?

[nalimilan]

@ViralBShah As I said, I think we should do something about #55 before a new release.

[EdSchouten]

Hi there!

Thought I'd better respond. Yes! I'll make sure to send you a pull-request for this. I'll hopefully manage to do this some time upcoming weekend, as I'm currently busy putting a laminated floor in my new apartment. ;-)

Ed

[ViralBShah]

Closed by #85.