Make OpenLibm build on AArch64 (aka ARM64).#100
Merged
ViralBShah merged 3 commits intoJuliaMath:masterfrom Oct 26, 2015
NuxiNL:aarch64
Merged
Make OpenLibm build on AArch64 (aka ARM64).#100ViralBShah merged 3 commits intoJuliaMath:masterfrom NuxiNL:aarch64
ViralBShah merged 3 commits intoJuliaMath:masterfrom
NuxiNL:aarch64
Conversation
The finite() function got standardized under the name isfinite(). Its use is therefore discouraged.
This makes it possible to build OpenLibm on ARM64 CPUs.
__always_inline is a (Free)BSD specific definition from cdefs.h. Compilers like Clang don't care about these keywords anyway, as they simply do whatever they like. It looks like we already removed this keyword from ld80/e_rem_pio2l.h as well. Apply exactly the same change to the ld128 version as well.
ViralBShah
added a commit
that referenced
this pull request
Oct 26, 2015
Make OpenLibm build on AArch64 (aka ARM64).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CloudABI's C library (cloudlibc) used a stock version of OpenLibm for its math functions. I recently added support for another architecture, AArch64, which required me to make a couple of small changes to the sources.
The following changes make it possible to use a stock version of OpenLibm once more.