Skip to content

Add make variable NOOPT to disable optimization flags#105

Merged
ViralBShah merged 1 commit intoJuliaMath:masterfrom
petercolberg:master
Nov 13, 2015
Merged

Add make variable NOOPT to disable optimization flags#105
ViralBShah merged 1 commit intoJuliaMath:masterfrom
petercolberg:master

Conversation

@petercolberg
Copy link
Copy Markdown
Contributor

This is used by Debian to build an unoptimized variant for debugging.

This is used by Debian to build an unoptimized variant for debugging.
ViralBShah added a commit that referenced this pull request Nov 13, 2015
[WIP] More makefile improvements
@ViralBShah ViralBShah merged commit e102501 into JuliaMath:master Nov 13, 2015
@petercolberg
Copy link
Copy Markdown
Contributor Author

Sorry for not being clear, WIP stands for work in progress…

@petercolberg
Copy link
Copy Markdown
Contributor Author

Could you undo the merge?

@ViralBShah
Copy link
Copy Markdown
Member

Of course. Didn't see that. I think I can only revert it for now. I have also sent you commit access so you could do it as well.

@ViralBShah
Copy link
Copy Markdown
Member

It's a protected branch, it turns out. If you don't mind, we can revert, or do a new PR for the remaining things.

@petercolberg
Copy link
Copy Markdown
Contributor Author

I noticed the protected branch. That is good practice anyway.

Then please leave it as is. The commit itself is good, I was just going to add more related commits to the pull request.

@nalimilan
Copy link
Copy Markdown
Contributor

Are we sure this -O3 flag is really useful as a default? My understanding is that it's very rarely a good idea, and should only be applied when benchmarking shows a real improvement.

@petercolberg petercolberg changed the title [WIP] More makefile improvements Add make variable NOOPT to disable optimization flags Nov 13, 2015
@nalimilan
Copy link
Copy Markdown
Contributor

Also, @ViralBShah, could you add @petercolberg and @xyproto (for Arch) to the packagers team? I just discovered this allows CCing all team members by writing @JuliaLang/distro-packagers.

@ViralBShah
Copy link
Copy Markdown
Member

I think -O2 should be good.

@ViralBShah
Copy link
Copy Markdown
Member

Added to distro-packagers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants