FreeBSD has different pkg-config dir: /usr/local/libdata/

[iblislin]

Also, let the prefix be configurable from outside(e.g make prefix=/path) .

[nalimilan]

This isn't needed AFAIK. All variables can be overridden already.

[iblislin]

Oh. ok i will remove it 😄

[nalimilan]

Out of curiosity, do you have any references about libdatadir? I've never seen other libraries use this variable in their makefiles, and it's not listed e.g. in the GNU make standard variables. So I wonder how FreeBSD handles all those programs that don't support it.

[iblislin]

@nalimilan Oh... libdatadir is just my naming, i'm willing to change it if you wish.
Some project use pkgconfigdir or whatever you can image.

We can find an example here: libzmq have pkgconfigdir configurable.
And there is a freebsd ports for it, set it correctly.

For the project which do not support it yet, we are encouraged to report to upstream. Or, we will make a patch for Makefile, uploud to freebsd ports. This patch will be apply during installation via ports.

[nalimilan]

OK. pkgconfigdir looks more common (there are autoconf macros about it), and I find it more explicit.

[nalimilan]

(But, really, this sounds like a heroic stance from FreeBSD people to decide to patch all upstream projects for a detail like that... :-)

[iblislin]

(Ha. BTW. There is still lots of project using bash script with #!/bin/bash, and this is not portable for bsd... I always do PR for this: "hey! our bash is here(/usr/local/bin/bash) ... #!/usr/env bash would be portable.")

[iblislin]

renaming done.

[nalimilan]

Please keep the default as $(libdir)/pkgconfig.

[iblislin]

Oops. sorry for that

[nalimilan]

You should move this code above, and use it instead of the unconditional definition. Also, use $(libdir) as I said above, since people may override it.

[iblislin]

hmm... you mean merge this if block in to the previous if block ?

[nalimilan]

No, I mean move this to the first place where you define pkgconfigdir.

[iblislin]

Oh, place it after line 15?
and... i try to understand your statement: "use it instead of the unconditional definition".
Would you explain more? I cannot follow your thinking right now.

[nalimilan]

Instead of line 13.

[nalimilan]

Thanks, LGTM.

@ViralBShah Good to go?

[iblislin]

@nalimilan Thanks for your patient reviewing. :)

[tkelman]

This looks okay to me