work around optimisation bugs for rint#116
Merged
ViralBShah merged 1 commit intomasterfrom Feb 23, 2016
Merged
Conversation
|
|
||
| default: all | ||
|
|
||
| # *int / *intf need to be built with -O0 |
Member
There was a problem hiding this comment.
Yes. See the failing test for nearbyint below that I had commented out a while back, and passes as a result of this.
Contributor
|
What does the optimizer do that causes these tests to fail? Is it a bug in the compiler, or is it a bug in the code? |
Member
Author
I'm not sure exactly, though I suspect it may be due to gcc's poor fenv |
Member
|
Verified on arm. |
ViralBShah
added a commit
that referenced
this pull request
Feb 23, 2016
work around optimisation bugs for rint
Member
|
@edelsohn mentions that gcc 5 implements much of this right for most targets. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the
rintfunctions (lrint,nearbyint) etc cause problems on ARM and power when compiled with optimisations. This disables optimisations for those functions, and enables them for all others. Also reenables a disable test.