Upstream local modifications to openlibm.#124
Merged
ViralBShah merged 2 commits intoJuliaMath:masterfrom Feb 27, 2016
NuxiNL:cloudabi-fixes
Merged
Upstream local modifications to openlibm.#124ViralBShah merged 2 commits intoJuliaMath:masterfrom NuxiNL:cloudabi-fixes
ViralBShah merged 2 commits intoJuliaMath:masterfrom
NuxiNL:cloudabi-fixes
Conversation
The current tradition of openlibm is to hide all of its internal symbols into the reserved system namespace. CloudABI has a check in place to ensure that its C library (which contains openlibm) to not place any unwanted symbols into the public namespace. openlibm seems to leak _scan_nan() in there, so we'd better add an additional underscore.
Contributor
|
I must say this sentence is confusing to me "Clang doesn't dislike it if you bitshift negative numbers, as the behaviour of it is undefined." :-) |
Clang doesn't like it if you bitshift negative numbers, as the behaviour of it is undefined. Solve this by first shifting, followed by negating. This was fixed similarly in FreeBSD.
Contributor
Author
|
Oh, sorry about that. Fixed! |
ViralBShah
added a commit
that referenced
this pull request
Feb 27, 2016
Upstream local modifications to openlibm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I currently have a small number of local changes that I need to apply on top of openlibm to properly integrate it into CloudABI's C library. It would be nice if I could get rid of them. ;-)