Split install into subtargets#140
Merged
tkelman merged 1 commit intoJuliaMath:masterfrom Jul 19, 2016
Merged
Conversation
|
|
||
| install: all openlibm.pc | ||
| install-static: libopenlibm.a | ||
| mkdir -p $(DESTDIR)$(shlibdir) |
Contributor
There was a problem hiding this comment.
should probably be libdir?
arjenroodselaar
force-pushed
the
split-install-target
branch
from
e2d4c6a to
58807a5
Compare
Author
|
@tkelman thank you for a review and apologies for the sloppy PR. The comments have been addressed. |
| mkdir -p $(DESTDIR)$(libdir) | ||
| cp -f -a libopenlibm.a $(DESTDIR)$(libdir)/ | ||
|
|
||
| install-shared: libopenlibm.$(OLM_MAJOR_MINOR_SHLIB_EXT) openlibm.pc |
Contributor
There was a problem hiding this comment.
does the openlibm.pc need to be a dependency here?
Contributor
|
not sloppy at all, thanks for the contribution! |
Member
|
Is this good to merge? |
Contributor
|
I think openlibm.pc should be deleted from the install-shared line but otherwise yes IMO |
When building a cross-compile toolchain for a freestanding platform one may not want to build and install shared objects.
arjenroodselaar
force-pushed
the
split-install-target
branch
from
58807a5 to
4002a91
Compare
Author
|
This should be good to go now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building a cross-compile toolchain for a freestanding platform one may not
want to build and install dynamic loadables.