Conversation
staticfloat
requested changes
Apr 6, 2018
| CP_A := cp -RpP | ||
| else | ||
| CP_A := cp -a | ||
| endif |
Contributor
There was a problem hiding this comment.
I actually think cp -RpP will work everywhere; so we can probably just use that.
This is the default compiler starting with OpenBSD 6.2, and has been installed by default on OpenBSD since 6.0.
OpenBSD does not support cp -a, and cp -RpP should work on all platforms.
In particular, OpenBSD already defines __GNUC_PREREQ__, __BEGIN_DECLS, and __warn_references. Hiding the definitions behind #ifndef guards avoids warnings when building.
Member
Author
|
I've separated this out into three distinct commits:
Note though that there are still a bunch of "attribute declaration must precede definition" warnings from the |
staticfloat
approved these changes
Apr 6, 2018
mato
added a commit
to mato/ocaml-freestanding
that referenced
this pull request
May 2, 2018
This is to get JuliaMath/openlibm#176, needed for OpenBSD changes in (was Merge commit 'f5a5c314d86e9d103f89bfa6fc7862b40a039570' into update-openlibm)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.