Skip to content

Add Windows testing with AppVeyor#177

Merged
ViralBShah merged 2 commits intomasterfrom
aa/windows
Jun 18, 2018
Merged

Add Windows testing with AppVeyor#177
ViralBShah merged 2 commits intomasterfrom
aa/windows

Conversation

@ararslan
Copy link
Copy Markdown
Member

@ararslan ararslan commented Apr 6, 2018

This runs on my AppVeyor account to avoid using up the JuliaLang paid AV queue.

Closes #165.

@ararslan ararslan requested a review from staticfloat April 6, 2018 22:57
@ararslan
Copy link
Copy Markdown
Member Author

ararslan commented Apr 6, 2018

Windows 32-bit is working, but 64-bit says

set PATH=C:\MinGW\bin;%PATH%
mingw32-make.exe ARCH=%ARCH%
gcc   -fno-gnu89-inline -fno-builtin -O3 -fPIC -m64 -std=c99 -Wall -IC:/projects/openlibm -IC:/projects/openlibm/include -IC:/projects/openlibm/amd64 -IC:/projects/openlibm/src -DASSEMBLER -D__BSD_VISIBLE -Wno-implicit-function-declaration -IC:/projects/openlibm/ld80 -c src/common.c -o src/common.c.o
src/common.c:1:0: warning: -fPIC ignored for target (all code is position independent)
 #include <openlibm_math.h>
 ^
src/common.c:1:0: sorry, unimplemented: 64-bit mode not compiled in
Make.inc:145: recipe for target 'src/common.c.o' failed
mingw32-make.exe: *** [src/common.c.o] Error 1
Command exited with code 2

@ararslan ararslan force-pushed the aa/windows branch 2 times, most recently from 5761507 to b4b984a Compare April 6, 2018 23:54
@ararslan
Copy link
Copy Markdown
Member Author

ararslan commented Apr 7, 2018

Okay, I'm stumped.

@nalimilan
Copy link
Copy Markdown
Contributor

mingw32-make.exe ARCH=%ARCH%

Should it be mingw64-make on 64-bit?

@ararslan
Copy link
Copy Markdown
Member Author

ararslan commented Apr 7, 2018

Currently it's working on 64-bit and not on 32-bit, so I don't think make is the problem.

@ararslan
Copy link
Copy Markdown
Member Author

ararslan commented Apr 7, 2018

Interesting, the problem on 32-bit now is that it can't find mingw32-make...

@ViralBShah
Copy link
Copy Markdown
Member

Any thoughts what needs to be done here?

@ararslan
Copy link
Copy Markdown
Member Author

I haven't looked at this in quite a while. I still have no idea why it isn't working and I don't have access to a Windows machine or VM to test locally.

@ViralBShah
Copy link
Copy Markdown
Member

Maybe disabling the 32-bit stuff so that the 64-bit stuff works would be still better. Right now appveyor just gives a red everywhere until we merge something here.

@ViralBShah ViralBShah closed this Jun 18, 2018
@ViralBShah ViralBShah reopened this Jun 18, 2018
@ViralBShah ViralBShah merged commit c782ca2 into master Jun 18, 2018
@ViralBShah ViralBShah deleted the aa/windows branch June 18, 2018 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants