Skip to content

Add s390(x) port#185

Merged
ViralBShah merged 1 commit intoJuliaMath:masterfrom
sharkcz:s390x
Nov 7, 2018
Merged

Add s390(x) port#185
ViralBShah merged 1 commit intoJuliaMath:masterfrom
sharkcz:s390x

Conversation

@sharkcz
Copy link
Copy Markdown
Contributor

@sharkcz sharkcz commented Nov 7, 2018

This is a s390(x) port with the following results

test/test-double
testing double (without inline functions)

Test suite completed:
  1118 test cases plus 932 tests for exception flags executed.
  All tests passed successfully.
test/test-float
testing float (without inline functions)
Failure: Test: yn (10, 2.0) == -129184.54220803928264
Result:
 is:         -1.29184562500000000000e+05  -0x1.f8a09000000000000000p+16
 should be:  -1.29184539062500000000e+05  -0x1.f8a08a00000000000000p+16
 difference:  2.34375000000000000000e-02   0x1.80000000000000000000p-6
 ulp       :  3.0000
 max.ulp   :  1.0000

Test suite completed:
  1101 test cases plus 923 tests for exception flags executed.
  1 errors occurred.

@ViralBShah
Copy link
Copy Markdown
Member

These changes look ok. Thanks.

@ViralBShah ViralBShah merged commit 65d7406 into JuliaMath:master Nov 7, 2018
@sharkcz
Copy link
Copy Markdown
Contributor Author

sharkcz commented Nov 7, 2018

Is there anything we can do for the precision issue with yn (10, 2.0) ?

@ViralBShah
Copy link
Copy Markdown
Member

Perhaps open a separate issue to track it? I say it is good enough for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants