Long double versions of math functions#69
Merged
ViralBShah merged 2 commits intomasterfrom Dec 4, 2014
Merged
Conversation
Bump version number and SO major version, since we have introduced new long double APIs.
ViralBShah
force-pushed
the
vs/longdouble
branch
from
7f8cc12 to
9ecf223
Compare
ViralBShah
added a commit
that referenced
this pull request
Dec 4, 2014
Long double versions of math functions
Closed
Contributor
|
This means we need to package a new version of openlibm, right? @nalimilan @sebastien-villemot |
Contributor
|
@staticfloat Yes, but I'd like the test failure at #55 to be fixed or worked around first. |
Contributor
There was a problem hiding this comment.
The last time I made the same mistake, @sebastien-villemot noted that we shouldn't raise the major version just because we added functions, but only when breaking compatibility for existing functions. Would you revert that change? Just raise SOMINOR instead.
Member
Author
|
We probably need to test this well and iron out issues. Since Julia does not use any of this yet, we do not need to release a new version anytime soon. |
ViralBShah
added a commit
that referenced
this pull request
Dec 5, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Import long double versions of a bunch of stuff from openbsd.