Skip to content

remove obsolete filter from CI #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aplavin merged 2 commits into from
Jun 10, 2025
Merged

remove obsolete filter from CI #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a62ed61
remove obsolete filter from CI
aplavin Jun 8, 2025
f50c070
upd test
aplavin Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ jobs:
- ubuntu-latest
- macOS-latest
- windows-latest
exclude:
- os: macOS-latest # Apple Silicon
version: '1.6'
steps:
- uses: actions/checkout@v4
- uses: julia-actions/setup-julia@v2
Expand Down
8 changes: 3 additions & 5 deletions test/perf.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,11 +176,9 @@ end
b_right = minimum(@benchmark compose_right_assoc($obj, $val) )
println("Right associative composition: $b_right")

@test b_default.allocs == 0
@test_broken b_right.allocs == 0
@test b_right.time ≈ b_default.time rtol=0.8
@test b_left.allocs == 0
@test b_left.time ≈ b_default.time rtol=0.8
# no matter which composition order is faster in Julia, ensure that optics use it by default
@test b_default.allocs == min(b_left.allocs, b_right.allocs)
@test b_default.time ≈ min(b_left.time, b_right.time) rtol=0.8
end

end
Loading