add getproperties method #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 32 38 +6
=========================================
+ Hits 32 38 +6
Continue to review full report at Codecov.
|
|
Anyone have time to review this? I need to resolve this to get #36 finished, and would like to avoid pirating those methods in other packages in the meantime |
jw3126
reviewed
Jan 29, 2021
|
Sorry for the late review. I wrote these comments weeks ago, but forgot to hit the submit button. |
rafaqz
force-pushed
the
getproperties
branch
3 times, most recently
from
9560db4 to
b22e94b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
getpropertiesmethod, primarily to handle construction of objects with undefined fields, but also more broadly useful for getting object fields as aNamedTuple. See #36.