Method `get_concrete_platform(::AbstractPlatform, ::Vector{CompilerShard})` not defined

[jessymilare]

That leads to errors whenever using any platform that is not of type Platform, e.g.:

julia> using BinaryBuilder

julia> BinaryBuilder.runshell(Linux(:x86_64);verbose=true)
[ Info: Checking to see if /home/jessica/Julia/libmpdec_builder/ is encrypted...
[ Info: Checking to see if /home/jessica/.julia/packages/BinaryBuilderBase/nW1CT/deps/ is encrypted...
ERROR: MethodError: no method matching get_concrete_platform(::Linux, ::Vector{BinaryBuilderBase.CompilerShard})
Closest candidates are:
  get_concrete_platform(::Platform, ::Vector{BinaryBuilderBase.CompilerShard}) at /home/jessica/.julia/packages/BinaryBuilderBase/nW1CT/src/utils.jl:23
  get_concrete_platform(::AnyPlatform, ::Vector{BinaryBuilderBase.CompilerShard}) at /home/jessica/.julia/packages/BinaryBuilderBase/nW1CT/src/utils.jl:61
  get_concrete_platform(::AbstractPlatform; kwargs...) at /home/jessica/.julia/packages/BinaryBuilderBase/nW1CT/src/utils.jl:55
  ...
Stacktrace:
 [1] get_concrete_platform(platform::Linux; kwargs::Base.Iterators.Pairs{Union{}, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
   @ BinaryBuilderBase ~/.julia/packages/BinaryBuilderBase/nW1CT/src/utils.jl:57
 [2] get_concrete_platform(platform::Linux)
   @ BinaryBuilderBase ~/.julia/packages/BinaryBuilderBase/nW1CT/src/utils.jl:56
 [3] BinaryBuilderBase.UserNSRunner(workspace_root::String; cwd::String, workspaces::Vector{Pair}, mappings::Vector{Pair}, platform::Linux, extra_env::Dict{String, String}, verbose::Bool, compiler_wrapper_path::String, toolchains_path::String, src_name::String, shards::Nothing, kwargs::Base.Iterators.Pairs{Union{}, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
   @ BinaryBuilderBase ~/.julia/packages/BinaryBuilderBase/nW1CT/src/UserNSRunner.jl:43
 [4] runshell(::Type{BinaryBuilderBase.UserNSRunner}, platform::Linux; verbose::Bool, kwargs::Base.Iterators.Pairs{Union{}, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
   @ BinaryBuilderBase ~/.julia/packages/BinaryBuilderBase/nW1CT/src/Runner.jl:1062
 [5] runshell(platform::Linux; kwargs::Base.Iterators.Pairs{Symbol, Bool, Tuple{Symbol}, NamedTuple{(:verbose,), Tuple{Bool}}})
   @ BinaryBuilderBase ~/.julia/packages/BinaryBuilderBase/nW1CT/src/Runner.jl:1054
 [6] top-level scope
   @ REPL[3]:1

[giordano]

The problem is using the platform as Linux(:x86_64), should use Platform("x86_64", "linux") instead. Linux(:x86_64) is a simple compatibility shim with the old way platforms were defined, but it doesn't work very well and should be avoided.

Did you find

BinaryBuilder.runshell(Linux(:x86_64);verbose=true)

suggested somewhere in documentation? We should remove it if that's the case

[jessymilare]

I found that call in another (unrelated) issue. However, in the section Build Tips, there is a link to Patchelf build_tarballs.jl which contains the lines:

platforms = [
    Linux(:x86_64, :glibc)
]

Creating a build_tarballs.jl with, e.g., Linux(:x86_64) in platforms also leads to the same problem.

[jessymilare]

In any case, if these constructors are to be avoided, I suggest they should be deprecated.

[giordano]

I'd love to 🙂

@staticfloat can we remove the old constructors Linux(...), etc? They don't really serve any purpose besides being confusing and causing errors.

[staticfloat]

Yeah, I think we've had them in place long enough for all of Yggdrasil to move away from using them. Let's do it.