Skip to content

[Prefix] Do not show warning if clashing files are the same #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2021
Merged

[Prefix] Do not show warning if clashing files are the same #154

merged 1 commit into from
Jun 28, 2021

Conversation

@giordano
Copy link
Member

@giordano giordano commented Jun 23, 2021 •
edited
Loading

A way to test this is to have the following dependencies:

dependencies = [
    Dependency("Libuuid_jll", v"2.34"),
    Dependency("Libmount_jll", v"2.34"),
]

The two artifacts have dozens of clashing files (all share/locale/*/LC_MESSAGES/util-linux.mo), but for the same version of the packages they are the same.

@giordano giordano requested a review from staticfloat June 23, 2021 23:35
staticfloat
staticfloat requested changes Jun 24, 2021
View reviewed changes
@staticfloat staticfloat merged commit 4b262c5 into JuliaPackaging:master Jun 28, 2021
@giordano giordano deleted the mg/prefix-cmp branch June 28, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@staticfloat staticfloat staticfloat requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@giordano @staticfloat