Skip to content

Fix error message for update_entity! when no instance is found for the given id #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tencnivel merged 8 commits into from
Apr 19, 2024
Merged

Fix error message for update_entity! when no instance is found for the given id #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
aee5bfc
changes
tencnivel Mar 3, 2024
a580517
'one_to_one' in the FK name is also interpreted as a 'one-to-one' rel…
tencnivel Mar 16, 2024
63ea1d8
add utility function dedup_colnames_colvalues!
tencnivel Mar 16, 2024
2481457
use dedup_colnames_colvalues! to handle columns that are referenced b…
tencnivel Mar 16, 2024
f32dc45
bump from 0.5.7 to 0.6.0
tencnivel Mar 16, 2024
63efb22
Merge remote-tracking branch 'origin/main' into fix-error-message
tencnivel Apr 19, 2024
fd80ca3
fix error message
tencnivel Apr 19, 2024
a4cbf1f
bump
tencnivel Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "PostgresORM"
uuid = "748b5efa-ed57-4836-b183-a38105a77fdd"
authors = ["Vincent Laugier <vincent.laugier@gmail.com>"]
version = "0.6.0"
version = "0.6.1"

[deps]
DataFrames = "a93c6f00-e57d-5684-b7b6-d8193f3e46c0"
Expand Down
15 changes: 11 additions & 4 deletions src/Controller/coreORM.update.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,10 +310,17 @@ function update_entity!(updated_object::IEntity,
dbconn)

if length(previous_state) == 0
throw(DomainError("Unable to retrieve an object of type[$data_type] "
* "with id[$(getproperty(updated_object,
orm_module.id_property))] from the database."
*" Remind that only existing existing objects can be updated."))

id_for_display = util_get_ids_cols_names_and_values(updated_object, dbconn) |>
dict -> join(["$k: $v" for (k, v) in dict], ", ")

throw(
DomainError(
"Unable to retrieve an object of type[$data_type] "
*"with id[$id_for_display] "
*"from the database. Remind that only existing objects can be updated."
)
)
end

previous_state = previous_state[1]
Expand Down