Fix false backport detection for non-default branch workflows#568
Merged
IanButterworth merged 3 commits intomasterfrom Apr 18, 2026
Merged
Fix false backport detection for non-default branch workflows#568IanButterworth merged 3 commits intomasterfrom
IanButterworth merged 3 commits intomasterfrom
Conversation
In Gitflow-style repos (e.g. MLJBase.jl) where the default branch is `develop` and releases happen on `master`, TagBot incorrectly marked every release as a backport because `branches_of_commit` returned `master` (a non-default branch). The backport flag now relies solely on `_is_backport()`, which checks whether a higher-version tag already exists—the actual semantic definition of a backport. Fixes #566 Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Gitflow-style repos (e.g. MLJBase.jl) where the default branch is
developand releases happen onmaster, TagBot incorrectly marked every release as a backport becausebranches_of_commitreturnedmaster(a non-default branch).The backport flag now relies solely on
_is_backport(), which checks whether a higher-version tag already exists—the actual semantic definition of a backport.Fixes #566