Example using a blend of hard type metadata and dicts for adding new … #158
Conversation
|
EDIT: want to review Johan's suggestion during this cycle -- could probably do it sooner. |
|
part of #147 discussion |
|
want to make sure @Affie is happy before we merge the twig, and then to master |
Codecov Report
@@ Coverage Diff @@
## feature/4Q19/issue147 #158 +/- ##
=========================================================
+ Coverage 50.16% 50.25% +0.08%
=========================================================
Files 28 28
Lines 1766 1769 +3
=========================================================
+ Hits 886 889 +3
Misses 880 880
Continue to review full report at Codecov.
|
|
You can go ahead, I'm not an expert when it comes to julia. |
|
unlikely to have a name change from (eg :max to :maximum), but if it does occur we will do so with deprecation cycle and minor version numbers. |
|
TLDR; hold off on merging this until we have spoken again please. hi @GearsAD , Johan convinced me on using So shall we change that now or later? I told Johan later, but I thought this was already merged. Perhaps we can just do it now before merging this. #148 already has it the way Johan suggested, we can maybe just introduce the name change to |
| timestamp::DateTime | ||
| tags::Vector{Symbol} | ||
| estimateDict::Dict{Symbol, Dict{Symbol, <: AbstractVariableEstimate}} | ||
| estimateDict::Dict{Symbol, PointParametricEstimates} |
There was a problem hiding this comment.
estimateDict::Dict{Symbol, <: AbstractPointParametric}
or whatever the chosen name for AbstractPointParametric is in the end
There was a problem hiding this comment.
from #148
<: AbstractVariableEstimate
| ppeType::Symbol | ||
| estimate::Vector{Float64} | ||
| """ | ||
| struct PointParametricEstimates |
|
Closed by design decision from #147 last few comments |
…estimates