Add Invalidations.yml#15
Merged
brenhinkeller merged 1 commit intoJuliaSIMD:mainfrom Sep 1, 2022
ranocha:patch-1
Merged
Conversation
Collaborator
|
Anything to be aware of before merging this? |
This is based on https://github.com/julia-actions/julia-invalidations. Adding such checks came up in https://discourse.julialang.org/t/potential-performance-regressions-in-julia-1-8-for-special-un-precompiled-type-dispatches-and-how-to-fix-them/86359. I suggest to add this check here since this package is widely used as a dependency. See also SciML/MuladdMacro.jl#26 and SciML/MuladdMacro.jl#29
ranocha
changed the title
Member
Author
|
I changed the commit message so that CI should run on this PR. Here is an example when this test passes: https://github.com/SciML/MuladdMacro.jl/runs/8121563802?check_suite_focus=true And here is a failing example: https://github.com/ranocha/InvalidationsTest.jl/runs/8134758303?check_suite_focus=true Other than that, it will just add a new CI run (that is relatively cheap). It will fail when a PR introduces new invalidations (and also report the numbers of invalidations for each PR). From there on, you can decide whether you want to ignore it or chase down the invalidations & fix them. Do you have any specific questions about this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on https://github.com/julia-actions/julia-invalidations. Adding such checks came up in https://discourse.julialang.org/t/potential-performance-regressions-in-julia-1-8-for-special-un-precompiled-type-dispatches-and-how-to-fix-them/86359. I suggest to add this check here since this package is widely used as a dependency.
See also SciML/MuladdMacro.jl#26 and SciML/MuladdMacro.jl#29