Fix Conjugate Operator and test all adjoint/transpose/conjugate operations #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
==========================================
+ Coverage 94.44% 96.58% +2.14%
==========================================
Files 6 6
Lines 522 527 +5
==========================================
+ Hits 493 509 +16
+ Misses 29 18 -11
Continue to review full report at Codecov.
|
abelsiqueira
force-pushed
the
increase-coverage
branch
from
3719b60 to
9ead579
Compare
dpo
requested changes
Nov 13, 2019
abelsiqueira
force-pushed
the
increase-coverage
branch
from
9ead579 to
8075150
Compare
dpo
requested changes
Nov 13, 2019
src/adjtrans.jl
Outdated
|
|
||
| function *(op :: ConjugateLinearOperator, v :: AbstractVector) | ||
| p = op.parent | ||
| return conj.(p * v) |
Member
There was a problem hiding this comment.
This line is buggy too. It should be conj.(p * conj.(v)).
Member
Author
There was a problem hiding this comment.
Fixed and added a test.
abelsiqueira
force-pushed
the
increase-coverage
branch
from
8075150 to
d11df69
Compare
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #115 and #116