Skip to content

Conversation

@abelsiqueira
Copy link
Member

Closes #113

@abelsiqueira abelsiqueira added this to the 1.0 milestone Nov 14, 2019
@dpo
Copy link
Member

dpo commented Nov 14, 2019

Thanks. I would suggest linalg.jl instead of factorization-operators.jl.

Also, BlockDiagonalOperator could go into special-operators.jl.

@coveralls
Copy link

coveralls commented Nov 14, 2019

Coverage Status

Coverage remained the same at 96.308% when pulling fcff9b0 on abelsiqueira:refactor into 644cd34 on JuliaSmoothOptimizers:master.

@codecov
Copy link

codecov bot commented Nov 14, 2019

Codecov Report

Merging #126 into master will not change coverage.
The diff coverage is 94.68%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #126   +/-   ##
======================================
  Coverage    96.3%   96.3%           
======================================
  Files           8      14    +6     
  Lines         623     623           
======================================
  Hits          600     600           
  Misses         23      23
Impacted Files Coverage Δ
src/lsr1.jl 98.48% <ø> (ø) ⬆️
src/LinearOperators.jl 100% <ø> (+5.59%) ⬆️
src/adjtrans.jl 98.71% <ø> (ø) ⬆️
src/lbfgs.jl 97.97% <ø> (ø) ⬆️
src/abstract.jl 100% <100%> (ø)
src/operations.jl 100% <100%> (ø)
src/linalg.jl 100% <100%> (ø)
src/cat.jl 100% <100%> (ø)
src/constructors.jl 72.72% <72.72%> (ø)
src/special-operators.jl 86.2% <86.2%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 644cd34...fcff9b0. Read the comment docs.

Copy link
Member

@dpo dpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@abelsiqueira abelsiqueira mentioned this pull request Dec 2, 2019
@abelsiqueira abelsiqueira merged commit 10c7cb7 into JuliaSmoothOptimizers:master Dec 2, 2019
@abelsiqueira abelsiqueira deleted the refactor branch December 2, 2019 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor source code

3 participants