Allows more generic matrix-vector products #140
Conversation
| if p.ctprod !== nothing | ||
| increase_nctprod(p) | ||
| return p.ctprod(v)::Vector{promote_type(T,U)} | ||
| return p.ctprod(v)::typeof(v).name.wrapper{promote_type(T,U), typeof(v).parameters[2]} |
There was a problem hiding this comment.
typeof(v).parameters[2] represents the dimension of the Array if it's dense (1 for Vectors) or the type of Integer that is used for storing coefficients when it's sparse.
Codecov Report
@@ Coverage Diff @@
## master #140 +/- ##
======================================
Coverage 96.3% 96.3%
======================================
Files 14 14
Lines 623 623
======================================
Hits 600 600
Misses 23 23
Continue to review full report at Codecov.
|
|
Do the Krylov.jl allocation tests pass? |
|
Is it possible to add a test to check that #139 is solved? |
|
Yes, allocation tests pass in Krylov.jl and I added a test to check that the ouptut of |
|
Thank you. |
3 participants
solve #139