Skip to content

Conversation

@dpo
Copy link
Member

@dpo dpo commented Mar 26, 2020

The scaling factor wasn't reset to 1 when resetting the operator. This lead to non-reproducible results.

@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #143 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
+ Coverage   96.30%   96.32%   +0.01%     
==========================================
  Files          14       14              
  Lines         623      625       +2     
==========================================
+ Hits          600      602       +2     
  Misses         23       23              
Impacted Files Coverage Δ
src/lbfgs.jl 98.00% <100.00%> (+0.02%) ⬆️
src/lsr1.jl 98.50% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e6112e...3057d60. Read the comment docs.

@abelsiqueira abelsiqueira merged commit 46ae3ab into master Mar 27, 2020
@abelsiqueira abelsiqueira deleted the qnops branch March 27, 2020 00:57
@abelsiqueira
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants