Skip to content

Conversation

@abelsiqueira
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Apr 9, 2020

Coverage Status

Coverage remained the same at 96.332% when pulling 9f26ca1 on abelsiqueira:deprecation-warning into 174c648 on JuliaSmoothOptimizers:master.

@codecov
Copy link

codecov bot commented Apr 9, 2020

Codecov Report

Merging #147 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #147   +/-   ##
=======================================
  Coverage   96.33%   96.33%           
=======================================
  Files          14       14           
  Lines         627      627           
=======================================
  Hits          604      604           
  Misses         23       23           
Impacted Files Coverage Δ
src/LinearOperators.jl 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 174c648...9f26ca1. Read the comment docs.

@dpo
Copy link
Member

dpo commented Apr 9, 2020

@abelsiqueira abelsiqueira force-pushed the deprecation-warning branch from 2b7a2fe to 9f26ca1 Compare April 9, 2020 14:11
@abelsiqueira
Copy link
Member Author

Thanks for the links. Updated using @deprecate and @test_deprecated. Also included LSR1 and moved the definitions of deprecated methods to deprecated.jl and the tests to test_deprecated.jl.

@amontoison
Copy link
Member

I updated the tests in Krylov.jl, some of them used the old version InverseLBFGSOperator(n, mem) (CGLS and CRLS). But the project.toml should be updated to take into account the new release 1.1 of LinearOperators.jl. I will prepare the release 5.0 of Krylov.jl.

@dpo dpo merged commit fdddaa1 into JuliaSmoothOptimizers:master Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants