Skip to content

LBFGS: remove allocations #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2020
Merged

LBFGS: remove allocations #155

merged 1 commit into from
Nov 28, 2020

Conversation

@dpo
Copy link
Member

@dpo dpo commented Nov 28, 2020

Basically:

    B = LBFGSOperator(n, mem=mem)
    H = InverseLBFGSOperator(n, mem=mem)
    x = rand(n)
    nallocs = @allocated B * x
    @test nallocs == 0
    nallocs = @allocated H * x
    @test nallocs == 0
    nallocs = @allocated diag!(B, x)
    @test nallocs == 0

@dpo dpo force-pushed the inplace-lbfgs branch 2 times, most recently from 3de1eb9 to c6375a9 Compare November 28, 2020 18:45
@dpo dpo merged commit 58ff611 into master Nov 28, 2020
@dpo dpo deleted the inplace-lbfgs branch November 28, 2020 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dpo