Skip to content

Conversation

@amontoison
Copy link
Member

@amontoison amontoison commented Feb 25, 2021

In Krylov.jl, we cannot use Symmetric matrices because PreallocatedLinearOperator(M ::Symmetric{T}; storagetype, symmetric) is not implemented.

This PR allows the use of symmetric and hermitian options even if they are not used with Symmetric, Hermitian and SymTriadiagonal wrappers.

https://github.com/JuliaSmoothOptimizers/Krylov.jl/blob/master/src/variants.jl#L24
https://github.com/JuliaSmoothOptimizers/Krylov.jl/blob/master/src/variants.jl#L62
https://github.com/JuliaSmoothOptimizers/Krylov.jl/blob/master/src/variants.jl#L65
https://github.com/JuliaSmoothOptimizers/Krylov.jl/blob/master/src/variants.jl#L73
https://github.com/JuliaSmoothOptimizers/Krylov.jl/blob/master/src/variants.jl#L76

@codecov
Copy link

codecov bot commented Feb 25, 2021

Codecov Report

Merging #165 (90c807c) into master (4eb3c4f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #165   +/-   ##
=======================================
  Coverage   96.92%   96.92%           
=======================================
  Files          14       14           
  Lines         748      748           
=======================================
  Hits          725      725           
  Misses         23       23           
Impacted Files Coverage Δ
src/PreallocatedLinearOperators.jl 96.77% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eb3c4f...cce17d0. Read the comment docs.

@amontoison
Copy link
Member Author

amontoison commented Feb 25, 2021

I think that it's more relevant to use the multiple dispatch of the PreallocatedLinearOperator method instead of adding variants in the src/variants.jl file of Krylov.jl.

@amontoison
Copy link
Member Author

@dpo is it fine if I merge this pull request ?

@amontoison amontoison merged commit e1a8e71 into JuliaSmoothOptimizers:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants