Skip to content

Conversation

@dpo
Copy link
Member

@dpo dpo commented Mar 29, 2021

Fixes #154

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #170 (f20acb0) into master (2384869) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
+ Coverage   96.92%   96.95%   +0.03%     
==========================================
  Files          14       14              
  Lines         748      756       +8     
==========================================
+ Hits          725      733       +8     
  Misses         23       23              
Impacted Files Coverage Δ
src/lbfgs.jl 97.58% <100.00%> (+0.08%) ⬆️
src/lsr1.jl 98.90% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2384869...f20acb0. Read the comment docs.

@github-actions
Copy link
Contributor

Package name latest stable
CaNNOLeS.jl
DCI.jl
JSOSolvers.jl
Krylov.jl
NLPModels.jl
NLPModelsModifiers.jl
Percival.jl
QuadraticModels.jl
SolverTools.jl

Arpack installation fails with Julia 1.0.
@dpo dpo requested a review from abelsiqueira March 29, 2021 18:34
@dpo
Copy link
Member Author

dpo commented Mar 29, 2021

We still support Julia 1.0 in our Project.toml and I think things work with 1.0 but

  1. we're not testing it with Github Actions;
  2. Arpack (that I'm now using in the tests) fails to install with Julia 1.0 (at least on FreeBSD).

Should we require Julia 1.3?

@abelsiqueira
Copy link
Member

We still support Julia 1.0 in our Project.toml and I think things work with 1.0 but

  1. we're not testing it with Github Actions;
  2. Arpack (that I'm now using in the tests) fails to install with Julia 1.0 (at least on FreeBSD).

Should we require Julia 1.3?

I think it's safe to drop 1.0.

@github-actions
Copy link
Contributor

Package name latest stable
CaNNOLeS.jl
DCI.jl
JSOSolvers.jl
Krylov.jl
NLPModels.jl
NLPModelsModifiers.jl
Percival.jl
QuadraticModels.jl
SolverTools.jl

dpo and others added 2 commits March 29, 2021 14:48
Co-authored-by: Abel Siqueira <abel.s.siqueira@gmail.com>
Co-authored-by: Abel Siqueira <abel.s.siqueira@gmail.com>
@github-actions
Copy link
Contributor

Package name latest stable
CaNNOLeS.jl
DCI.jl
JSOSolvers.jl
Krylov.jl
NLPModels.jl
NLPModelsModifiers.jl
Percival.jl
QuadraticModels.jl
SolverTools.jl

@github-actions
Copy link
Contributor

Package name latest stable
CaNNOLeS.jl
DCI.jl
JSOSolvers.jl
Krylov.jl
NLPModels.jl
NLPModelsModifiers.jl
Percival.jl
QuadraticModels.jl
SolverTools.jl

@github-actions
Copy link
Contributor

Package name latest stable
CaNNOLeS.jl
DCI.jl
JSOSolvers.jl
Krylov.jl
NLPModels.jl
NLPModelsModifiers.jl
Percival.jl
QuadraticModels.jl
SolverTools.jl

@dpo dpo merged commit 5cb36a4 into master Mar 29, 2021
@dpo dpo deleted the bfgs_mul branch March 29, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError

3 participants