Skip to content

Conversation

@abelsiqueira
Copy link
Member

Closes #97

@coveralls
Copy link

coveralls commented Sep 5, 2019

Coverage Status

Coverage increased (+0.2%) to 92.465% when pulling 4052165 on abelsiqueira:fix-cat into 3462b64 on JuliaSmoothOptimizers:master.

@codecov
Copy link

codecov bot commented Sep 5, 2019

Codecov Report

Merging #98 into master will increase coverage by 0.37%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
+ Coverage    93.4%   93.77%   +0.37%     
==========================================
  Files           5        5              
  Lines         500      530      +30     
==========================================
+ Hits          467      497      +30     
  Misses         33       33
Impacted Files Coverage Δ
src/LinearOperators.jl 93.5% <100%> (+0.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a00282...b7ea04e. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 5, 2019

Codecov Report

Merging #98 into master will increase coverage by 0.39%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
+ Coverage   92.49%   92.89%   +0.39%     
==========================================
  Files           6        6              
  Lines         533      563      +30     
==========================================
+ Hits          493      523      +30     
  Misses         40       40
Impacted Files Coverage Δ
src/LinearOperators.jl 94.42% <100%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3462b64...4052165. Read the comment docs.

@dpo
Copy link
Member

dpo commented Sep 17, 2019

Does @closure really help type stability??!?

@abelsiqueira
Copy link
Member Author

According to @code_warntype, yes.

@abelsiqueira
Copy link
Member Author

Closing in favor of #99

@abelsiqueira abelsiqueira deleted the fix-cat branch November 11, 2019 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exponentially long precompilation times with hcat and LinearOperators

3 participants