Skip to content

Conversation

@tmigot
Copy link
Member

@tmigot tmigot commented Dec 15, 2021

Fix #71
I used the column first ordering to be consistent with L.202 in NLPModelsJuMP.jl.

@dpo
Copy link
Member

dpo commented Dec 15, 2021

cc @farhadrclass

@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #105 (7cbd1b8) into main (ce68dfe) will increase coverage by 1.49%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
+ Coverage   98.06%   99.55%   +1.49%     
==========================================
  Files         658      658              
  Lines        5636     5632       -4     
==========================================
+ Hits         5527     5607      +80     
+ Misses        109       25      -84     
Impacted Files Coverage Δ
src/ADNLPProblems/clplatea.jl 100.00% <100.00%> (+100.00%) ⬆️
src/ADNLPProblems/clplateb.jl 100.00% <100.00%> (+100.00%) ⬆️
src/ADNLPProblems/clplatec.jl 100.00% <100.00%> (+100.00%) ⬆️
src/ADNLPProblems/fminsrf2.jl 100.00% <100.00%> (+100.00%) ⬆️
src/Meta/clplatea.jl 100.00% <0.00%> (+100.00%) ⬆️
src/Meta/clplateb.jl 100.00% <0.00%> (+100.00%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce68dfe...7cbd1b8. Read the comment docs.

@tmigot tmigot mentioned this pull request Dec 15, 2021
@tmigot tmigot requested a review from amontoison December 15, 2021 21:21
Copy link
Member

@amontoison amontoison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@tmigot tmigot merged commit 53356f2 into main Dec 18, 2021
@tmigot tmigot deleted the matrix-unknown branch December 18, 2021 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Converting JuMP models to ADNLPModels format

4 participants