add tetra.jl #190
add tetra.jl #190
Conversation
tmigot
left a comment
tmigot
left a comment
There was a problem hiding this comment.
Thanks @MohamedLaghdafHABIBOULLAH ! It already looks very good, I only have a couple of small comments. Please, check duct12 and duct15 as there seem to be some problems with these two.
src/ADNLPProblems/tetra.jl
Outdated
| end | ||
|
|
||
| function f(y) | ||
| return sum(nfrob(e,y)/(3*area(e,y)^(2/3)) for e=1:E) |
There was a problem hiding this comment.
| return sum(nfrob(e,y)/(3*area(e,y)^(2/3)) for e=1:E) | |
| return sum(nfrob(e,y)/(3*area(e,y)^(2//3)) for e=1:E) |
ensures type stability.
src/ADNLPProblems/tetra.jl
Outdated
|
|
||
| include("../../data/tetra_duct12.jl") | ||
| export tetra_duct12 | ||
| tetra_duct12(;kwargs...) = tetra(xe_duct12, TETS_duct12, Const_duct12; kwargs...) |
There was a problem hiding this comment.
| tetra_duct12(;kwargs...) = tetra(xe_duct12, TETS_duct12, Const_duct12; kwargs...) | |
| tetra_duct12(;kwargs...) = tetra(xe_duct12, TETS_duct12, Const_duct12; name = "tetra_duct12", kwargs...) |
Can you also add names for the others?
src/ADNLPProblems/tetra.jl
Outdated
|
|
||
| include("../../data/tetra_duct15.jl") | ||
| export tetra_duct15 | ||
| tetra_duct15(;kwargs...) = tetra(xe_duct15, TETS_duct15, Const_duct15; kwargs...) |
There was a problem hiding this comment.
It seems that xe_duct15 is a matrix and not a vector
src/ADNLPProblems/tetra.jl
Outdated
|
|
||
| include("../../data/tetra_duct12.jl") | ||
| export tetra_duct12 | ||
| tetra_duct12(;kwargs...) = tetra(xe_duct12, TETS_duct12, Const_duct12; kwargs...) |
There was a problem hiding this comment.
Also, for some reason, this one returns an error. Can you verify?
tmigot
left a comment
tmigot
left a comment
There was a problem hiding this comment.
I think I found why the tests were failing, we should give a specific name even for the default data.
Co-authored-by: tmigot <tangi.migot@gmail.com>
Co-authored-by: tmigot <tangi.migot@gmail.com>
Co-authored-by: tmigot <tangi.migot@gmail.com>
Co-authored-by: tmigot <tangi.migot@gmail.com>
Co-authored-by: tmigot <tangi.migot@gmail.com>
Co-authored-by: tmigot <tangi.migot@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #190 +/- ##
==========================================
- Coverage 99.89% 99.25% -0.64%
==========================================
Files 724 741 +17
Lines 6401 6589 +188
==========================================
+ Hits 6394 6540 +146
- Misses 7 49 +42
Continue to review full report at Codecov.
|
2 participants
No description provided.