Skip to content

Redundant return in R2 #149

@MaxenceGollier

Description

@MaxenceGollier

There is a return that should not be there in [R2.jl].
(https://github.com/JuliaSmoothOptimizers/RegularizedOptimization.jl/blob/c37c5126660ce90ad8145785343b78ebe7fa7b7d/src/R2_alg.jl)

return R2(
reg_nlp,
x = x0,
atol = options.ϵa,
rtol = options.ϵr,
neg_tol = options.neg_tol,
verbose = options.verbose,
max_iter = options.maxIter,
max_time = options.maxTime,
σmin = options.σmin,
η1 = options.η1,
η2 = options.η2,
ν = options.ν,
γ = options.γ,
)
return stats

This does not change anything to the results because we do want to return R2(...).
I am opening a PR to remove it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions