Skip to content

Conversation

@dpo
Copy link
Member

@dpo dpo commented Jan 27, 2024

The values of ν and θ should depend on the floating-point type.

@geoffroyleconte @rjbaraldi @MohamedLaghdafHABIBOULLAH Do the values I put in make sense?

@dpo dpo requested a review from geoffroyleconte January 27, 2024 21:48
@codecov
Copy link

codecov bot commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (19a26b2) 63.39% compared to head (5446bce) 61.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
- Coverage   63.39%   61.54%   -1.86%     
==========================================
  Files          11       11              
  Lines        1295     1295              
==========================================
- Hits          821      797      -24     
- Misses        474      498      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

Here are the
demos-results

@MohamedLaghdafHABIBOULLAH
Copy link
Collaborator

MohamedLaghdafHABIBOULLAH commented Feb 9, 2024

@dpo , I believe it won't affect the results (as it can be seen in demos_results) that much because in general we use R = Float64, so it will be like 7e^-4. However, I will rerun the numerical experiments for R2N to see if it will change the results.

@dpo dpo merged commit 966b9ac into master Feb 20, 2024
@dpo dpo deleted the ROSolverOptions-types branch February 20, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants