LM: only recompute Jacobian norm if problem is nonlinear #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@dpo pour cette PR j'ai modifié le critère d'arrêt du sous solveur de LM pour qu'il soit le même que R2N |
dpo
reviewed
Dec 14, 2024
dpo
reviewed
Dec 30, 2024
dpo
reviewed
Dec 30, 2024
Member
|
@MohamedLaghdafHABIBOULLAH Please rebase and revise this PR. |
Collaborator
|
As discussed, I suggest to modify the default value of |
Collaborator
Author
Done, could you review this PR @MaxenceGollier ? |
dpo
reviewed
Feb 25, 2025
Member
dpo
left a comment
dpo
left a comment
There was a problem hiding this comment.
Could you also please rename this PR so it has a descriptive title?
MohamedLaghdafHABIBOULLAH
changed the title
MohamedLaghdafHABIBOULLAH
changed the title
dpo
changed the title
… different subsolver criterion stop
Co-authored-by: Dominique <dominique.orban@gmail.com>
MohamedLaghdafHABIBOULLAH
force-pushed
the
LM-update
branch
from
303b5e0 to
579cf06
Compare
Member
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We enable the use of R2DH as a subsolver with different stopping criteria for the subproblem.
Remark: this PR uses the input_struct.jl defined here: #153