-
Notifications
You must be signed in to change notification settings - Fork 10
Paper draft #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
MohamedLaghdafHABIBOULLAH
wants to merge
42
commits into
JuliaSmoothOptimizers:paper
from
MohamedLaghdafHABIBOULLAH:paper-draft
Closed
Paper draft #205
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
ebd13d6
add paper example
MohamedLaghdafHABIBOULLAH 158fc0a
minor error
MohamedLaghdafHABIBOULLAH 8c75806
add bib
MohamedLaghdafHABIBOULLAH 595c372
correct the typos and bib
MohamedLaghdafHABIBOULLAH 49cf76b
Update GitHub Actions workflow for PDF generation
MohamedLaghdafHABIBOULLAH 3722a04
Update draft-pdf.yml
MohamedLaghdafHABIBOULLAH 2bb4f05
Apply suggestions from code review
MohamedLaghdafHABIBOULLAH 33510b3
incorporate suggestions
MohamedLaghdafHABIBOULLAH 3b67bb7
add opt bib
MohamedLaghdafHABIBOULLAH afd7753
correct the title
MohamedLaghdafHABIBOULLAH 269bad8
incorporate Dominique comments
MohamedLaghdafHABIBOULLAH bc756ee
Add the examples
MohamedLaghdafHABIBOULLAH 3c68da0
clarify the comparison
MohamedLaghdafHABIBOULLAH b06581b
add first results on fh
MohamedLaghdafHABIBOULLAH 3754018
Test if the workflow works
MohamedLaghdafHABIBOULLAH 3ac9d45
Apply suggestions from code review
MohamedLaghdafHABIBOULLAH 7c1856a
include new changes
MohamedLaghdafHABIBOULLAH f7cca94
Supprimer jso-packages.pdf du fichier .gitignore
MohamedLaghdafHABIBOULLAH bff5892
reviwe the paper draft
MohamedLaghdafHABIBOULLAH f4c0c2e
Update paper/paper.md
MohamedLaghdafHABIBOULLAH f523011
Refine documentation by removing hyperparameter tuning section and en…
MohamedLaghdafHABIBOULLAH 4152a56
Enhance documentation by refining the section on Hessians, clarifying…
MohamedLaghdafHABIBOULLAH 5cf8f24
final version
MohamedLaghdafHABIBOULLAH bb2b23b
add nonmonotone and use opnorm=20 for all solvers
MohamedLaghdafHABIBOULLAH 30c8c8f
Update paper/paper.md
MohamedLaghdafHABIBOULLAH ad42d67
Update paper/paper.md
MohamedLaghdafHABIBOULLAH 157b986
minor changes
MohamedLaghdafHABIBOULLAH 552c243
second final version
MohamedLaghdafHABIBOULLAH 1ba1185
update results with master rebased
MohamedLaghdafHABIBOULLAH 66ed713
minor comments
MohamedLaghdafHABIBOULLAH a9a4985
Fix typos and improve clarity in paper.md
MohamedLaghdafHABIBOULLAH 872cbd0
Improve clarity in examples section of paper.md
MohamedLaghdafHABIBOULLAH fc1f5a6
Refine shifted proximal operator definitions and enhance clarity in r…
MohamedLaghdafHABIBOULLAH 8dc9fdc
Incorporate Dominique comments
MohamedLaghdafHABIBOULLAH d10eb41
Update benchmark results in Benchmark.tex after debugging with constr…
MohamedLaghdafHABIBOULLAH 8d5d675
Update benchmark results in Benchmark.tex to reflect accurate perform…
MohamedLaghdafHABIBOULLAH 037ca76
Improve clarity in the description of splitting schemes in the model-…
MohamedLaghdafHABIBOULLAH c0b0104
Refine descriptions in the model-based framework section of paper.md …
MohamedLaghdafHABIBOULLAH f92e92e
Refactor benchmarking scripts and update results table
MohamedLaghdafHABIBOULLAH 3f1c939
Adding a note on gradient evaluations for the LM solver.
MohamedLaghdafHABIBOULLAH a2e0b9e
Adding a note on gradient evaluations for the LM solver.
MohamedLaghdafHABIBOULLAH ab8ef54
Clarify solver statistics and gradient evaluation details for the LM …
MohamedLaghdafHABIBOULLAH File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,11 +21,32 @@ jobs: | |
| journal: joss | ||
| # This should be the path to the paper within your repo. | ||
| paper-path: paper/paper.md | ||
| - name: Upload | ||
| - name: Upload pdf artifact | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: paper | ||
| # This is the output path where Pandoc will write the compiled | ||
| # PDF. Note, this should be the same directory as the input | ||
| # paper.md | ||
| path: paper/paper.pdf | ||
| - name: Create release | ||
| if: github.event_name == 'push' | ||
| uses: rymndhng/release-on-push-action@master | ||
| id: release | ||
| with: | ||
| bump_version_scheme: patch | ||
| tag_prefix: v | ||
| release_body: "" | ||
| use_github_release_notes: true | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| - name: Upload PDF to release | ||
| if: github.event_name == 'push' | ||
| uses: svenstaro/upload-release-action@v2 | ||
| with: | ||
| repo_token: ${{ secrets.GITHUB_TOKEN }} | ||
| file: paper/paper.pdf | ||
| asset_name: joss-draft.pdf | ||
| tag: ${{ steps.release.outputs.tag_name }} | ||
| overwrite: true | ||
| body: "" | ||
|
Comment on lines
+32
to
+52
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Actually, it looks like it does not work. |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| paper/examples/Manifest.toml | ||
| paper/jats/paper.jats | ||
| paper/jats/jso-packages.pdf | ||
| paper/paper.pdf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| module BenchUtils | ||
|
|
||
| using ProximalAlgorithms | ||
| using ProximalCore | ||
| using NLPModels | ||
|
|
||
| export Counting, reset_counters!, make_adnlp_compatible! | ||
|
|
||
| (f::AbstractNLPModel)(x) = obj(f,x) | ||
|
|
||
| function ProximalAlgorithms.value_and_gradient(f::AbstractNLPModel, x) | ||
| return obj(f,x), grad(f, x) | ||
| end | ||
|
|
||
| "Wrapper compteur pour f ou g (compte #obj, #∇f, #prox)." | ||
| mutable struct Counting{T} | ||
| f::T | ||
| eval_count::Int | ||
| gradient_count::Int | ||
| prox_count::Int | ||
| end | ||
| Counting(f::T) where {T} = Counting{T}(f, 0, 0, 0) | ||
|
|
||
| # f(x) | ||
| (f::Counting)(x) = (f.eval_count += 1; f.f(x)) | ||
|
|
||
| # (f, ∇f) | ||
| function ProximalAlgorithms.value_and_gradient(f::Counting, x) | ||
| f.eval_count += 1 | ||
| f.gradient_count += 1 | ||
| return ProximalAlgorithms.value_and_gradient(f.f, x) | ||
| end | ||
|
|
||
| # prox!(y, g, x, γ) | ||
| function ProximalCore.prox!(y, g::Counting, x, γ) | ||
| g.prox_count += 1 | ||
| return ProximalCore.prox!(y, g.f, x, γ) | ||
| end | ||
|
|
||
| "Réinitialise les compteurs d’un Counting." | ||
| reset_counters!(c::Counting) = (c.eval_count = 0; c.gradient_count = 0; c.prox_count = 0; nothing) | ||
|
|
||
| end # module |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to do this with Cirrus.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest uploading the paper manually for now, since I haven’t figured out how to make the workflow upload the PDF automatically:
https://github.com/MohamedLaghdafHABIBOULLAH/RegularizedOptimization.jl/actions/runs/18014594356