R2N : Patch sub_kwargs and add sub_kwargs for TR #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #218 +/- ##
===========================================
+ Coverage 61.53% 85.55% +24.02%
===========================================
Files 11 12 +1
Lines 1292 1544 +252
===========================================
+ Hits 795 1321 +526
+ Misses 497 223 -274 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
@MaxenceGollier Thank you, it looks good for me! |
MaxenceGollier
changed the title
dpo
approved these changes
Sep 18, 2025
Member
|
This branch must be rebased. |
MaxenceGollier
force-pushed
the
patch_kwargs
branch
from
e50fac0 to
5800371
Compare
MaxenceGollier
merged commit e2e817a
into
JuliaSmoothOptimizers:master
13 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dpo @MohamedLaghdafHABIBOULLAH
closes #217
I added a field for TR as well because why not.