-
Notifications
You must be signed in to change notification settings - Fork 10
Add prox_evals to solver_specific #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prox_evals to solver_specific #222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds tracking of proximal evaluations to three solver algorithms by introducing a prox_evals counter. The counter tracks both initial proximal evaluations and additional evaluations from subsolvers during the optimization process.
- Adds
prox_evalscounter initialization and tracking to TR, R2N, and LM algorithms - Increments counter at algorithm start and after each subsolver execution
- Stores the count in solver-specific statistics for monitoring
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/TR_alg.jl | Adds proximal evaluation tracking to Trust Region algorithm |
| src/R2N.jl | Adds proximal evaluation tracking to R2N algorithm |
| src/LM_alg.jl | Adds proximal evaluation tracking to Levenberg-Marquardt algorithm |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
All tests have been interrupted @MohamedLaghdafHABIBOULLAH can you try again please ? |
eb9ffc8 to
4744db8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #222 +/- ##
===========================================
+ Coverage 61.53% 86.15% +24.62%
===========================================
Files 11 13 +2
Lines 1292 1575 +283
===========================================
+ Hits 795 1357 +562
+ Misses 497 218 -279 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks. |
217cb7c
into
JuliaSmoothOptimizers:master
@dpo @MaxenceGollier
I’ve added the number of proximal evaluations. for R2N, LM, and TR, and I’m still waiting on LMTR.
Note that for R2, R2DH, and TRDH, using
stats.iteralone is sufficient to capture the number of proximal evaluations.