Skip to content

Conversation

@dpo
Copy link
Member

@dpo dpo commented Oct 1, 2025

No description provided.

Co-authored-by: Maxence Gollier <134112149+MaxenceGollier@users.noreply.github.com>
Co-authored-by: Maxence Gollier <134112149+MaxenceGollier@users.noreply.github.com>
Co-authored-by: YD1 <77547975+d1Lab@users.noreply.github.com>
Co-authored-by: Maxence Gollier <134112149+MaxenceGollier@users.noreply.github.com>
…hancing non-monotone strategies description for improved clarity.
Co-authored-by: Maxence Gollier <134112149+MaxenceGollier@users.noreply.github.com>
Co-authored-by: Maxence Gollier <134112149+MaxenceGollier@users.noreply.github.com>
- Removed old Benchmark.tex file and replaced it with a new version containing updated results.
- Consolidated benchmarking logic into a single Benchmark.jl file, removing separate benchmark-nnmf.jl and benchmark-svm.jl files.
- Updated comparison-config.jl to modify tolerance values and adjust configurations for benchmarking.
- Adjusted imports in Bench-utils.jl to remove unused dependencies and streamline the code.
- Updated Project.toml to include new dependencies for PrettyTables and ProximalAlgorithms.
- Modified the paper.md to correctly reference the new Benchmark.tex file location.
@MohamedLaghdafHABIBOULLAH
Copy link
Collaborator

MohamedLaghdafHABIBOULLAH commented Oct 1, 2025

Thank you @dpo!
But I think we should not merge it in master.

@dpo dpo changed the base branch from master to paper October 1, 2025 11:58
@dpo
Copy link
Member Author

dpo commented Oct 1, 2025

I changed the base branch to paper.

@MaxenceGollier MaxenceGollier merged commit e2bd43e into paper Oct 3, 2025
1 check passed
@MaxenceGollier MaxenceGollier deleted the MohamedLaghdafHABIBOULLAH-paper-draft branch October 3, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants