Skip to content

Conversation

@geoffroyleconte
Copy link
Member

@geoffroyleconte geoffroyleconte commented Feb 9, 2023

I had to change the initial $\nu$ value for the NNMF demo.

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Base: 52.14% // Head: 52.67% // Increases project coverage by +0.52% 🎉

Coverage data is based on head (92320d6) compared to base (6d2d8ec).
Patch coverage: 88.88% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   52.14%   52.67%   +0.52%     
==========================================
  Files          10       10              
  Lines         978      991      +13     
==========================================
+ Hits          510      522      +12     
- Misses        468      469       +1     
Impacted Files Coverage Δ
src/R2_alg.jl 89.55% <88.88%> (+0.29%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Here are the
demos-results

@geoffroyleconte geoffroyleconte requested a review from dpo February 9, 2023 21:22
Copy link
Member

@dpo dpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thank you!

@dpo dpo merged commit cb7f9d7 into JuliaSmoothOptimizers:master Feb 12, 2023
@geoffroyleconte geoffroyleconte deleted the r2-constr branch February 14, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants