Skip to content

Conversation

@geoffroyleconte
Copy link
Member

Not adding NNMF demos with LMTR since the problem is not implemented with a NLSModel.

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Base: 52.67% // Head: 52.28% // Decreases project coverage by -0.39% ⚠️

Coverage data is based on head (2f7fa09) compared to base (21c938a).
Patch coverage: 75.00% of modified lines in pull request are covered.

❗ Current head 2f7fa09 differs from pull request most recent head 0c957d1. Consider uploading reports for the commit 0c957d1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   52.67%   52.28%   -0.39%     
==========================================
  Files          10       10              
  Lines         991      983       -8     
==========================================
- Hits          522      514       -8     
  Misses        469      469              
Impacted Files Coverage Δ
src/LMTR_alg.jl 88.07% <75.00%> (-0.28%) ⬇️
src/R2_alg.jl 89.25% <0.00%> (-0.30%) ⬇️
src/TR_alg.jl 87.23% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Here are the
demos-results

@geoffroyleconte geoffroyleconte requested a review from dpo February 9, 2023 22:18
Copy link
Member

@dpo dpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@github-actions
Copy link
Contributor

Here are the
demos-results

@geoffroyleconte geoffroyleconte merged commit 2ad6ff2 into JuliaSmoothOptimizers:master Feb 14, 2023
@geoffroyleconte geoffroyleconte deleted the lmtr-constr branch February 14, 2023 23:08
@github-actions
Copy link
Contributor

Here are the
demos-results

rjbaraldi pushed a commit that referenced this pull request May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants