LM and LMTR with TRDH #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Here are the |
geoffroyleconte
force-pushed
the
lm-lmtr-trdh
branch
from
8a38e4d to
1724fb0
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #95 +/- ##
==========================================
+ Coverage 58.10% 59.19% +1.09%
==========================================
Files 11 11
Lines 1222 1223 +1
==========================================
+ Hits 710 724 +14
+ Misses 512 499 -13
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Contributor
|
Here are the |
Member
Author
|
@dpo can I merge this PR? |
dpo
requested changes
May 31, 2023
src/LMTR_alg.jl
Outdated
|
|
||
| local l_bound, u_bound | ||
| if has_bounds(nls) | ||
| if (has_bounds(nls) || subsolver == TRDH) |
Member
There was a problem hiding this comment.
Could you add a new bool variable treats_bounds = has_bounds(nls) || subsolver == TRDH?
geoffroyleconte
force-pushed
the
lm-lmtr-trdh
branch
from
1724fb0 to
d853bf2
Compare
dpo
approved these changes
May 31, 2023
Contributor
|
Here are the |
Contributor
|
Here are the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.