-
Notifications
You must be signed in to change notification settings - Fork 65
add faster sum/any/all/iszero #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
But LinearAlgebra doesn't know about |
|
Wait. This doesn't apply to |
dkarrasch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is all actually handled well, see my comment in the original issue. What is missing is a count specialization for Bool sparse arrays.
sure but what ever the parent is, shouldn't Transpose just forward it to the parent? like always as these are not position aware functions |
|
I see what you mean. Like iszero(x::AdjOrTrans) = iszero(parent(x))right? |
|
yeah |
|
closed in favor #244 |
closes #237
i'll write tests tomorrow
would it make sense that the functions for transpose/adjoint be added to LinearAlgebra.jl?
can nonzeros be larger than nnz? there are code where it would be valid and code that it would not be.