Skip to content

Add trailing whitespace check#720

Merged
ViralBShah merged 2 commits into
mainfrom
whitespace-check
May 24, 2026
Merged

Add trailing whitespace check#720
ViralBShah merged 2 commits into
mainfrom
whitespace-check

Conversation

@ViralBShah
Copy link
Copy Markdown
Member

@ViralBShah ViralBShah commented May 24, 2026

Summary

  • Adds .ci/check-whitespace.jl, adapted from JuliaLang/julia's contrib/check-whitespace.jl, with patterns trimmed to files relevant to this repo (*.jl, *.md, *.yml, *Makefile).
  • Adds .github/workflows/Whitespace.yml to run the check on push to main and on pull requests.
  • Fixes pre-existing whitespace violations (trailing whitespace, trailing blank lines, a non-breaking space) so the new check passes.

Companion to JuliaLang/LinearAlgebra.jl#1633.

Test plan

  • julia .ci/check-whitespace.jl reports no issues locally
  • Whitespace workflow passes in CI

🤖 Generated with Claude Code

ViralBShah and others added 2 commits May 23, 2026 22:31
Adds .ci/check-whitespace.jl (adapted from JuliaLang/julia's
contrib/check-whitespace.jl) and a GitHub Actions workflow that runs
it on push/PR. Also fixes pre-existing whitespace violations across
the source and test trees.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented May 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.35%. Comparing base (6adadc8) to head (9075ba2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #720      +/-   ##
==========================================
- Coverage   84.36%   84.35%   -0.02%     
==========================================
  Files          13       13              
  Lines        9376     9376              
==========================================
- Hits         7910     7909       -1     
- Misses       1466     1467       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ViralBShah ViralBShah merged commit 5926672 into main May 24, 2026
10 of 11 checks passed
@ViralBShah ViralBShah deleted the whitespace-check branch May 24, 2026 03:00
ViralBShah added a commit that referenced this pull request May 25, 2026
## Summary
- Adds `.ci/check-whitespace.jl`, adapted from [JuliaLang/julia's
`contrib/check-whitespace.jl`](https://github.com/JuliaLang/julia/blob/master/contrib/check-whitespace.jl),
with patterns trimmed to files relevant to this repo (`*.jl`, `*.md`,
`*.yml`, `*Makefile`).
- Adds `.github/workflows/Whitespace.yml` to run the check on push to
`main` and on pull requests.
- Fixes pre-existing whitespace violations (trailing whitespace,
trailing blank lines, a non-breaking space) so the new check passes.

Companion to JuliaLang/LinearAlgebra.jl#1633.

## Test plan
- [x] `julia .ci/check-whitespace.jl` reports no issues locally
- [x] Whitespace workflow passes in CI

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Viral B. Shah <ViralBShah@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
(cherry picked from commit 5926672)
@ViralBShah ViralBShah added the backport 1.13 Change should be backported to release-1.13 label May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 1.13 Change should be backported to release-1.13

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant