Fix affprop() random CI failures #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #246 +/- ##
==========================================
- Coverage 95.36% 95.29% -0.08%
==========================================
Files 18 18
Lines 1316 1317 +1
==========================================
Hits 1255 1255
- Misses 61 62 +1
☔ View full report in Codecov by Sentry. |
alyst
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
affprob()seems to fail in CI tests from time to time.After looking at the debug info added by this PR, it looks like the failures are related to a numerical error accumulating in availability and response matrices.
It results in a very small negative
A[i,i] + R[i,i], which leads to the empty exemplars.It looks like sklearn addresses that by adding small amount of noise: _affinity_propagation().