Adds a weighted mode call #611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM |
nalimilan
reviewed
Dec 3, 2020
Member
nalimilan
left a comment
nalimilan
left a comment
There was a problem hiding this comment.
Thanks, looks mostly good.
(For reference, we don't use countmap because it requires iterating over the dict to find what's the largest value. This could probably be fixed by allowing the countmap implementation do keep track of the highest value, but that can be left for later.)
Member
Author
|
Hmm, I guess this PR need the #621 to be merged? |
Member
|
Unfortunately yes. |
nalimilan
approved these changes
Dec 3, 2020
nalimilan
requested changes
Dec 3, 2020
Member
nalimilan
left a comment
nalimilan
left a comment
There was a problem hiding this comment.
Sorry I forgot that the docstrings need to mention the new methods.
rofinn
force-pushed
the
rf/weighted-mode
branch
from
36e4109 to
882e49c
Compare
Member
Author
|
macOS 1.0 failing test seems unrelated? |
Member
|
This is a bit untypical for a random failure it is also weight related code (fweight) in Line 168 in 217da39 |
Member
|
I think it's just bad luck. #624 is an attempt at fixing this. |
nalimilan
reviewed
Dec 4, 2020
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
nalimilan
approved these changes
Dec 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like there's a bit of repeated code between other
modemethods and thecountscode, but I've attempted to keep these changes isolated to what I need for now.This PR would let me remove this https://github.com/invenia/Impute.jl/blob/master/src/utils.jl#L31