Skip to content

Conversation

@nalimilan
Copy link
Member

Negative weights can give errors. They should probably be disallowed but that's a more fundamental change.

@nalimilan nalimilan merged commit 8075e28 into master Dec 5, 2020
@nalimilan nalimilan deleted the nl/test branch December 5, 2020 11:03
@mschauer
Copy link
Member

mschauer commented Dec 5, 2020

Might be not about negative weights (the random numbers are non-negative), but issues with having less than 1 observation (in weight sum) when you estimate the standard deviation with correction and frequency weights.

@nalimilan
Copy link
Member Author

Ah indeed. Maybe we should check that in varcorrection.

@mschauer
Copy link
Member

mschauer commented Dec 5, 2020

Also the question what is the right correction for weighted samples. I think we must have talked about this before, otherwise perhaps that wouldn't have come to my mind easily.

@nalimilan
Copy link
Member Author

What do you mean? We have different kinds of corrections which are appropriate for the corresponding kind of weight. But currently we don't check that the sum indicates that there's at least one observation, which is indeed required for the correction to make any sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants