Skip to content

Conversation

@frapac
Copy link
Member

@frapac frapac commented Aug 24, 2016

  • improve initialization of SDDP
  • remove overwriting of display function

+ improve initialization of SDDP
+ remove overwriting of display function
@codecov-io
Copy link

codecov-io commented Aug 24, 2016

Current coverage is 93.95% (diff: 94.87%)

Merging #113 into dev-nightly will increase coverage by 0.10%

@@           dev-nightly       #113   diff @@
=============================================
  Files               10         10          
  Lines              683        678     -5   
  Methods              0          0          
  Messages             0          0          
  Branches             0          0          
=============================================
- Hits               641        637     -4   
+ Misses              42         41     -1   
  Partials             0          0          

Powered by Codecov. Last update 06382c6...c782b9f


##########
# Estimate final upper bound with a great number of simulations:
if (verbose>0) && (param.compute_upper_bound != 0)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am lost about what param.compute_upper_bound is exactly supposed to be :

  • 0 -> never computed
  • -1 -> computed at the end with param.monteCarloSize scenarios ? more ?
  • 10 -> computed every 10 iterations with a fixed set of param.monteCarloSize scenarios, and at the end with xxx scenarios ?

I would prefer to default to (i.e. compute_upper_bound = 0) the case where we compute the upb only at the end.

@leclere
Copy link
Collaborator

leclere commented Aug 24, 2016

Ok for me, once the 0 and -1 are exchanged.

@frapac frapac merged commit 5a1f860 into dev-nightly Aug 25, 2016
@frapac frapac deleted the doc-refactoring branch August 25, 2016 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants