Don't use cached version of UnicodeData.txt #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: JuliaLang/julia#19725, UnicodeData.txt is now being cached in JuliaLang/julia's build.
Member
|
Sorry for not commenting earlier, but what's the idea here? Why shouldn't it be cached in utf8proc too, which is an independent project? Also, why is EastAsianWidth.txt still cached? |
Contributor
|
We're using the same caching server, but the fact that they're separate projects means the unicode versions might not always match. The caching server only saves files by the basename I believe - we could alternately fix it to use the full url in the cached path. |
Member
|
Got it, thanks. But better do the same for EastAsianWidth.txt, no? |
Contributor
|
I don't think we download that one for julia, do we? |
Member
|
No, but if we think it's OK not to cache the first file, why is it necessary to cache the second one? Reading this file without the context, it's quite confusing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: JuliaLang/julia#19725, UnicodeData.txt is now being cached in JuliaLang/julia's build. cc @tkelman