Skip to content

Conversation

@ericphanson
Copy link
Member

I've been making some changes and was worried about introducing issues that cause failures to package CI. So I thought I'd add some tests. Here I've added Oceananigans, cc @giordano.

Copy link
Contributor

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! My only concern for you is that this will add a bit of precompilation latency for all the tests, but at least it's a real world large-ish codebase with many interesting corner cases.

Comment on lines +6 to +7
[compat]
Oceananigans = "=0.103.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to strictly fix the version, because I'm slowly but steadily going through all the modules to fix everything 😁

ericphanson and others added 2 commits January 11, 2026 01:19
Co-authored-by: Mosè Giordano <765740+giordano@users.noreply.github.com>
@ericphanson
Copy link
Member Author

I've put them in a separate CI workflow, and just pushed a commit to parallelize over packages (though there's only 1 currently) so hopefully it's not too bad. My plan is to not run them when testing locally since failures here are unexpected (our normal tests should catch most things) but they'll run in PRs to catch issues before merge (hopefully).

@giordano
Copy link
Contributor

Ok, it takes 3 minutes in total starting from scratch, it's not too bad after all. CUDA (which depends on DataFrames, which takes a while) is a pkgextension nowadays in Oceananigans.

@ericphanson ericphanson merged commit 5517e00 into main Jan 11, 2026
8 checks passed
@ericphanson ericphanson deleted the eph/integration-tests branch January 11, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants