Skip to content

Conversation

@quinnj
Copy link
Member

@quinnj quinnj commented Oct 3, 2025

No description provided.

@quinnj
Copy link
Member Author

quinnj commented Oct 3, 2025

I believe this should be good to merge, but waiting on @DilumAluthge to fix our JuliaWeb bots used for testing w/ the new 2fa requirements. @DilumAluthge, if you're up for fixing then re-running these tests and merging, that'd be great. Otherwise, just let me know when the bot is fixed and I'll re-trigger things.

@DilumAluthge DilumAluthge reopened this Oct 6, 2025
@DilumAluthge
Copy link
Member

DilumAluthge commented Oct 6, 2025

@quinnj Test failures look real?


Reviews: Error During Test at /home/runner/work/GitHub.jl/GitHub.jl/test/read_only_api_tests.jl:201
  Got exception outside of a @test
  MethodError: no method matching Review(::PullRequest, ::JSON.Object{String, Any})
  The type `Review` exists, but no method is defined for this combination of argument types when trying to construct it.
  
  Closest candidates are:
    Review(::Any, ::Any, ::Any, ::Any, ::Any)
     @ GitHub ~/work/GitHub.jl/GitHub.jl/src/issues/reviews.jl:2
    Review(::Union{Nothing, PullRequest}, ::Union{Nothing, Int64}, ::Union{Nothing, Owner}, ::Union{Nothing, String}, ::Union{Nothing, String})
     @ GitHub ~/work/GitHub.jl/GitHub.jl/src/issues/reviews.jl:2
    Review(::PullRequest, ::Dict)
     @ GitHub ~/work/GitHub.jl/GitHub.jl/src/issues/reviews.jl:9
    ...
  
  Stacktrace:
    [1] (::GitHub.var"#225#226"{PullRequest})(x::JSON.Object{String, Any})
      @ GitHub ~/work/GitHub.jl/GitHub.jl/src/issues/reviews.jl:20
    [2] iterate
      @ ./generator.jl:48 [inlined]
    [3] _collect(c::Vector{Any}, itr::Base.Generator{Vector{Any}, GitHub.var"#225#226"{PullRequest}}, ::Base.EltypeUnknown, isz::Base.HasShape{1})
      @ Base ./array.jl:811
    [4] collect_similar(cont::Vector{Any}, itr::Base.Generator{Vector{Any}, GitHub.var"#225#226"{PullRequest}})
      @ Base ./array.jl:720
    [5] map(f::Function, A::Vector{Any})
      @ Base ./abstractarray.jl:3371
    [6] reviews(api::GitHub.GitHubWebAPI, repo::Repo, pr::PullRequest; options::@Kwargs{auth::GitHub.OAuth2})
      @ GitHub ~/work/GitHub.jl/GitHub.jl/src/issues/reviews.jl:20
    [7] reviews
      @ ~/work/GitHub.jl/GitHub.jl/src/issues/reviews.jl:17 [inlined]
    [8] #reviews#227
      @ ./none:0 [inlined]
    [9] macro expansion
      @ ~/work/GitHub.jl/GitHub.jl/test/read_only_api_tests.jl:203 [inlined]
   [10] macro expansion
      @ /opt/hostedtoolcache/julia/1.11.7/x64/share/julia/stdlib/v1.11/Test/src/Test.jl:1709 [inlined]
   [11] top-level scope
      @ ~/work/GitHub.jl/GitHub.jl/test/read_only_api_tests.jl:202
   [12] include(fname::String)
      @ Main ./sysimg.jl:38
   [13] macro expansion
      @ ~/work/GitHub.jl/GitHub.jl/test/runtests.jl:10 [inlined]
   [14] macro expansion
      @ /opt/hostedtoolcache/julia/1.11.7/x64/share/julia/stdlib/v1.11/Test/src/Test.jl:1709 [inlined]
   [15] top-level scope
      @ ~/work/GitHub.jl/GitHub.jl/test/runtests.jl:8
   [16] include(fname::String)
      @ Main ./sysimg.jl:38
   [17] top-level scope
      @ none:6

@codecov
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.86%. Comparing base (942e814) to head (c972c6c).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #235      +/-   ##
==========================================
- Coverage   55.19%   54.86%   -0.34%     
==========================================
  Files          37       37              
  Lines         904      904              
==========================================
- Hits          499      496       -3     
- Misses        405      408       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DilumAluthge
Copy link
Member

(I think that CI is only passing on Julia 1.6 because it's using JSON v0.21.4 on Julia 1.6.)

@quinnj quinnj merged commit 05144ef into master Oct 6, 2025
10 of 11 checks passed
@quinnj quinnj deleted the jq-json-1.0 branch October 6, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants