-
Notifications
You must be signed in to change notification settings - Fork 63
Add compat/support for JSON 1.0 #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I believe this should be good to merge, but waiting on @DilumAluthge to fix our JuliaWeb bots used for testing w/ the new 2fa requirements. @DilumAluthge, if you're up for fixing then re-running these tests and merging, that'd be great. Otherwise, just let me know when the bot is fixed and I'll re-trigger things. |
|
@quinnj Test failures look real? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #235 +/- ##
==========================================
- Coverage 55.19% 54.86% -0.34%
==========================================
Files 37 37
Lines 904 904
==========================================
- Hits 499 496 -3
- Misses 405 408 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
(I think that CI is only passing on Julia 1.6 because it's using JSON v0.21.4 on Julia 1.6.) |
No description provided.